Andrew Morton wrote:
On Wed, 4 Oct 2006 18:49:01 +0200 (CEST)
Jiri Slaby <[email protected]> wrote:
Char, remove unneded termbits redefinitions
No need to redefine termbits in char tree.
drivers/char/ip2/ip2main.c:2498: error: 'B153600' undeclared (first use in this function)
drivers/char/ip2/ip2main.c:2498: error: (Each undeclared identifier is reported only once
drivers/char/ip2/ip2main.c:2498: error: for each function it appears in.)
drivers/char/ip2/ip2main.c:2500: error: 'B307200' undeclared (first use in this function)
Unless you're a sparc user, methinks you didn't compile this one.
I suppose an appropriate fix would be to move the B153600 and B307200
definitions into include/asm-*/termbits.h (those which don't already have it).
But that's just a guess.
Hum, I thought I had at least compiled it :/. Next time I'll double-check!
The problem is, that sparc defines it in a little bit different way.
ip2 does this: <<EOF
#ifndef B153600
# define B153600 0010005
#endif
#ifndef B307200
# define B307200 0010006
#endif
#ifndef B921600
# define B921600 0010007
#endif
EOF
and sparc termbits looks like this: <<EOF
/* This is what we can do with the Zilogs. */
#define B76800 0x00001005
/* This is what we can do with the SAB82532. */
#define B153600 0x00001006
#define B307200 0x00001007
#define B614400 0x00001008
#define B921600 0x00001009
EOF
This diversity should be eliminated, I guess. What do char-folks think about
this? Should we move this bits into asm-specific directories?
sorry,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
