Re: [PATCH 3/9] sound/oss/msnd_pinnacle.c: ioremap balanced with iounmap

On Fri, 06 Oct 2006 11:08:57 +0530
Amol Lad <[email protected]> wrote:

>  msnd_pinnacle.c |   10 ++++++++++

This driver fails to check that ioremap() actually succeeded.  Hence with
this patch we can end up doing iounmap(NULL).

Now it _could_ be that the kernel permits iounmap(NULL).  But I don't
recall that being the rule, and from my reading the powerpc 64-bit iounmap
(at least) will go splat if we do this to it.  Most other implementations
will permit iounmap(NULL) by accident.  
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 3/9] sound/oss/msnd_pinnacle.c: ioremap balanced with iounmap
    • From: Amol Lad <[email protected]>

• References:
  • [PATCH 3/9] sound/oss/msnd_pinnacle.c: ioremap balanced with iounmap
    • From: Amol Lad <[email protected]>

• Prev by Date: [PATCH 6/6] Char: mxser_new, register tty devices on the fly
• Next by Date: Re: [discuss] Re: Please pull x86-64 bug fixes
• Previous by thread: [PATCH 3/9] sound/oss/msnd_pinnacle.c: ioremap balanced with iounmap
• Next by thread: Re: [PATCH 3/9] sound/oss/msnd_pinnacle.c: ioremap balanced with iounmap
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]