On Friday 06 October 2006 13:22, Andrew Morton wrote:
> On Thu, 5 Oct 2006 21:52:28 -0700
>
> Vadim Lobanov <[email protected]> wrote:
> > As long as the previous patch replaces the guts of fs/file.c, it makes
> > sense to tidy up all the code within. This work includes:
> > code simplification via refactoring,
> > elimination of unnecessary code paths,
> > extensive commenting throughout the entire file, and
> > other minor cleanups and consistency tweaks.
> > This patch does not contain any functional modifications.
> >
> > This is the last patch in the series. All the code should now be sparkly
> > clean.
>
> This (wordwrapped) patch should have been the first in the series, not the
> last.
Didn't know. Was hoping to gather this kind of feedback after the first
submission attempt.
> So I'll drop this one.
This patch still has a lot of useful (and I'd argue necessary) fixes for
incorrect comments and confusing code ordering. It's especially nice for
those who might try to understand what's going on inside fs/file.c, so seems
a shame to drop it. I could...
... hold on to it until the other fdtable changes hit mainline.
or
... redo this one with just the bare essentials.
or
... drop it completely.
-- Vadim Lobanov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
