Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4]

On Fri, Oct 06, 2006 at 10:33:19PM +0200, Jan Engelhardt wrote:
> 
> >+ *   the massive ternary operator construction
> >+	(sizeof(n) <= 4) ?			\
> >+	__ilog2_u32(n) :			\
> >+	__ilog2_u64(n)				\
> 
> Should not this be: sizeof(n) <= sizeof(u32)

Were you planning on porting Linux to a machine with non-8-bit-bytes any
time soon?  Because there's a lot more to fix than this.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4]
    • From: David Howells <[email protected]>
  • Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4]
    • From: Jan Engelhardt <[email protected]>

• References:
  • [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4]
    • From: David Howells <[email protected]>
  • Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4]
    • From: Jan Engelhardt <[email protected]>

• Prev by Date: Re: [PATCH] Cast removal
• Next by Date: Re: [PATCH 5/5] ioremap balanced with iounmap for drivers/char/watchdog/s3c2410_wdt.c
• Previous by thread: Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4]
• Next by thread: Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4]
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]