On Fri, 06 Oct 2006 10:27:05 +0530
Amol Lad <[email protected]> wrote:
> ioremap must be balanced by an iounmap and failing to do so can result
> in a memory leak.
>
> Tested (compilation only):
> - using allmodconfig
> - making sure the files are compiling without any warning/error due to
> new changes
>
> Signed-off-by: Amol Lad <[email protected]>
> ---
> epca.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletion(-)
> ---
> diff -uprN -X linux-2.6.19-rc1-orig/Documentation/dontdiff linux-2.6.19-rc1-orig/drivers/char/epca.c linux-2.6.19-rc1/drivers/char/epca.c
> --- linux-2.6.19-rc1-orig/drivers/char/epca.c 2006-10-05 14:00:42.000000000 +0530
> +++ linux-2.6.19-rc1/drivers/char/epca.c 2006-10-05 14:50:00.000000000 +0530
> @@ -1474,8 +1474,11 @@ static void post_fep_init(unsigned int c
> if ((bd->type == PCXEVE || bd->type == PCXE) && (readw(memaddr + XEPORTS) < 3))
> shrinkmem = 1;
> if (bd->type < PCIXEM)
> - if (!request_region((int)bd->port, 4, board_desc[bd->type]))
> + if (!request_region((int)bd->port, 4, board_desc[bd->type])) {
> + iounmap(bd->re_map_membase);
> + bd->re_map_membase = NULL;
> return;
> + }
> memwinon(bd, 0);
>
I think this will do the wrong thing if (bd->type >= PCIXEM). Maybe it's
OK, but it's not immediately obvious from a quick reading.
I'm quite worried about changes in crufty old drivers like these - if we
break them, the breakage will take a *long* time to be discovered. Too
late for us to fix them.
Plus a lot of them are just plain badly coded, so extra care is needed to
understand the tricks which they're playing.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
