Re: [Patch] Memory leak in drivers/usb/serial/airprime.c

Hmm. And I really thought I'd plugged all the leaks....

Acked-by: Andy Gay <[email protected]>

On Thu, 2006-10-05 at 12:31 +0200, Eric Sesterhenn wrote:
> hi,
> 
> the commit http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=5dda171202f94127e49c12daf780cdae1b4e668b
> added a memory leak. In case we cant allocate an urb, we dont free
> the buffer and leak it. Coverity id #1438
> 
> Signed-off-by: Eric Sesterhenn <[email protected]>
> 
> --- linux-2.6.19-rc1/drivers/usb/serial/airprime.c.orig	2006-10-05 12:25:56.000000000 +0200
> +++ linux-2.6.19-rc1/drivers/usb/serial/airprime.c	2006-10-05 12:26:35.000000000 +0200
> @@ -133,6 +133,7 @@ static int airprime_open(struct usb_seri
>  		}
>  		urb = usb_alloc_urb(0, GFP_KERNEL);
>  		if (!urb) {
> +			kfree(buffer);
>  			dev_err(&port->dev, "%s - no more urbs?\n",
>  				__FUNCTION__);
>  			result = -ENOMEM;
> 
> 
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [Patch] Memory leak in drivers/usb/serial/airprime.c
    • From: Eric Sesterhenn <[email protected]>

• Prev by Date: Re: 2.6.19-rc1 genirq causes either boot hang or "do_IRQ: cannot handle IRQ -1"
• Next by Date: [PATCH] fix mesh compile errors after irq changes
• Previous by thread: [Patch] Memory leak in drivers/usb/serial/airprime.c
• Next by thread: [PATCH] sched: fix a kerneldoc error on is_init()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]