Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage

Vivek Goyal wrote:

Hi Eric,

I have added cld in the regenerated patch below.

No, the cld needs to be earlier. It turns out this isn't the first use of string instructions.

I think I am going to add DF=0 as a documented entry condition; it definitely seems all current Linux kernels require it.

Also one more minor nit. stosb relies on being %es set properly. By the
time control reaches loader_ok, i could not find %es being set explicitly

hence I am assuming we are relying on bootloader to set it up for us.

Maybe we can be little more paranoid and setup the %es before stosb. I
have done this change too in the attached patch. Pleaese have a look.
I know little about assembly code.

%es being set is part of the requirements list, although it *would* be better to not rely on any segment registers being set at all (only rely on %cs.)

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: [email protected] (Eric W. Biederman)

• References:
  • [RFC][PATCH 0/12] ELF Relocatable x86 bzImage (V2)
    • From: Vivek Goyal <[email protected]>
  • [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: Vivek Goyal <[email protected]>
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: Vivek Goyal <[email protected]>

• Prev by Date: Re: 2.6.19-rc1 genirq causes either boot hang or "do_IRQ: cannot handle IRQ -1"
• Next by Date: [PATCH 00/10] -mm: generic clocksource API -v2
• Previous by thread: Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
• Next by thread: Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]