Re: [PATCH 4/5] ioremap balanced with iounmap for drivers/char/rio/rio_linux.c

Ar Gwe, 2006-10-06 am 16:51 +0530, ysgrifennodd Amol Lad:
> > > +
> > > +		if (hp->Caddr)
> > > +			iounmap(hp->Caddr);
> > >  	}
> > 
> > I don't think this is sufficient because it may be unmapped earlier on
> > error but hp->Caddr is not then cleared .
> 
> Is this fine ?
> 
> Signed-off-by: Amol Lad <[email protected]>

Acked-by: Alan Cox <[email protected]>

Thanks

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH 4/5] ioremap balanced with iounmap for drivers/char/rio/rio_linux.c
  - From: Amol Lad <[email protected]>
- Re: [PATCH 4/5] ioremap balanced with iounmap for drivers/char/rio/rio_linux.c
  - From: Alan Cox <[email protected]>
- Re: [PATCH 4/5] ioremap balanced with iounmap for drivers/char/rio/rio_linux.c
  - From: Amol Lad <[email protected]>

Prev by Date: [PATCH 2/4] LOG2: Alter roundup_pow_of_two() so that it can use a ilog2() on a constant [try #4]
Next by Date: [PATCH 19-rc1] Fix typos in /Documentation : 'U-Z'
Previous by thread: Re: [PATCH 4/5] ioremap balanced with iounmap for drivers/char/rio/rio_linux.c
Next by thread: [PATCH 3/5] ioremap balanced with iounmap for drivers/char/moxa.c
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]