Re: [PATCH 4/12] i386: define __pa_symbol()

Vivek Goyal wrote:

> +/* __pa_symbol should be used for C visible symbols.
> +   This seems to be the official gcc blessed way to do such arithmetic. */
> +#define __pa_symbol(x)          __pa(RELOC_HIDE((unsigned long)x,0))

#define __pa_symbol(x)          __pa(RELOC_HIDE((unsigned long)(x),0))
                                                               ^^^
... should be better. You should not rely on RELOC_HIDE implementation.

		Franck
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 4/12] i386: define __pa_symbol()
    • From: Vivek Goyal <[email protected]>

• References:
  • [RFC][PATCH 0/12] ELF Relocatable x86 bzImage (V2)
    • From: Vivek Goyal <[email protected]>
  • [PATCH 4/12] i386: define __pa_symbol()
    • From: Vivek Goyal <[email protected]>
  • Re: [PATCH 4/12] i386: define __pa_symbol()
    • From: Franck Bui-Huu <[email protected]>
  • Re: [PATCH 4/12] i386: define __pa_symbol()
    • From: Vivek Goyal <[email protected]>

• Prev by Date: Re: tracepoint maintainance models
• Next by Date: [PATCH] i386 add X86_FEATURE_PEBS and detection
• Previous by thread: Re: [PATCH 4/12] i386: define __pa_symbol()
• Next by thread: Re: [PATCH 4/12] i386: define __pa_symbol()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]