Re: [PATCH] make mach-generic/summit.c compile on UP

On Thu, 2006-10-05 at 19:16 +0200, Jiri Kosina wrote:
> Hi,
> 
> arch/i386/mach-generic/summit.c doesn't compile (neither in current 
> mainline git tree, nor in 2.6.18-mm3) when CONFIG_SMP is not set:
> 
> In file included from arch/i386/mach-generic/summit.c:17:
> include/asm/mach-summit/mach_apic.h: In function 'apicid_to_node':
> include/asm/mach-summit/mach_apic.h:91: error: 'apicid_2_node' undeclared (first use in this function)
> include/asm/mach-summit/mach_apic.h:91: error: (Each undeclared identifier is reported only once
> include/asm/mach-summit/mach_apic.h:91: error: for each function it appears in.)
> Is the patch below correct?

Well I guess it would fix the apicid_2_node build error but I can't
think of a single good reason to be in a config where you would need any
of the summit code in UP.  Perhaps a kconfig or makefile change in the
right spot would be better. 

Can you send along your config file so I can better understand?  I seem
to be able to build i386 UP just fine.  

Thanks, 
  Keith 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] make mach-generic/summit.c compile on UP
    • From: Andi Kleen <[email protected]>
  • Re: [PATCH] make mach-generic/summit.c compile on UP
    • From: Jiri Kosina <[email protected]>

• References:
  • [PATCH] make mach-generic/summit.c compile on UP
    • From: Jiri Kosina <[email protected]>

• Prev by Date: Re: ohci1394 regression in 2.6.19-rc1 (was Re: Merge window closed: v2.6.19-rc1)
• Next by Date: Re: ohci1394 regression in 2.6.19-rc1 (was Re: Merge window closed: v2.6.19-rc1)
• Previous by thread: [PATCH] make mach-generic/summit.c compile on UP
• Next by thread: Re: [PATCH] make mach-generic/summit.c compile on UP
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]