Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage

Eric W. Biederman wrote:

In the lazy programmer school of fixes.

I haven't really tested this in any configuration.
But reading video.S it does use variable in the bootsector.
It does seem to initialize the variables before use.
But obviously something is missed.

By zeroing the uninteresting parts of the bootsector just after we
have determined we are loaded ok.  We should ensure we are

always in a known state the entire time.

Andrew if I am right about the cause of your video not working
when you set an enhanced video mode this should fix your boot
problem.

I just noticed we're using string instructions in setup.S, without forcing DF = 0 anywhere. There should be a "cld" near the top.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC][PATCH 0/12] ELF Relocatable x86 bzImage (V2)
    • From: Vivek Goyal <[email protected]>
  • [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: Vivek Goyal <[email protected]>
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
    • From: [email protected] (Eric W. Biederman)

• Prev by Date: [PATCH][RFC] net/ipv6: seperate sit driver to extra module
• Next by Date: [PATCH 1/10] BC: introduce atomic_dec_and_lock_irqsave()
• Previous by thread: Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
• Next by thread: Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]