On Wed, 4 Oct 2006 17:56:30 -0700 Reinette Chatre <[email protected]> wrote: > + if (is_user) { > + if (__get_user(c, buf++)) > + return -EFAULT; > + } > + else > + c = *buf++; Is this actually needed? __get_user(kernel_address) works OK and (believe it or not, given all the stuff it involves) boils down to a single instruction. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] bitmap: separate bitmap parsing for user buffer and kernel buffer
- From: Andi Kleen <[email protected]>
- Re: [PATCH] bitmap: separate bitmap parsing for user buffer and kernel buffer
- From: "H. Peter Anvin" <[email protected]>
- Re: [PATCH] bitmap: separate bitmap parsing for user buffer and kernel buffer
- From: Inaky Perez-Gonzalez <[email protected]>
- Re: [PATCH] bitmap: separate bitmap parsing for user buffer and kernel buffer
- References:
- [PATCH] bitmap: separate bitmap parsing for user buffer and kernel buffer
- From: Reinette Chatre <[email protected]>
- [PATCH] bitmap: separate bitmap parsing for user buffer and kernel buffer
- Prev by Date: Re: 2.6.18-mm2 boot failure on x86-64
- Next by Date: PROBLEM: Hardlock with 2.6.1[678] on Abit AI7, ICH5 + XFS, SATA under heavy I/O load
- Previous by thread: [PATCH] bitmap: separate bitmap parsing for user buffer and kernel buffer
- Next by thread: Re: [PATCH] bitmap: separate bitmap parsing for user buffer and kernel buffer
- Index(es):
 |