RE: [Patch 1/6] megaraid_sas: FW transition and q size changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello James,

	I will do the clean up and check before submitting patches next
time.	

Regards,

Sumant 

-----Original Message-----
From: James Bottomley [mailto:[email protected]] 
Sent: Wednesday, October 04, 2006 10:56 AM
To: Patro, Sumant
Cc: [email protected]; [email protected]; [email protected];
[email protected]
Subject: Re: [Patch 1/6] megaraid_sas: FW transition and q size changes

On Tue, 2006-10-03 at 12:28 -0700, Sumant Patro wrote:
> Resubmitting with one addition (item f mentioned below)
> 
> This patch has the following enhancements :
>         a. handles new transition states of FW to support controller
hotplug. 
>         b. It reduces by 1 the maximum cmds that the driver may send
to FW. 
>         c. Sends "Stop Processing" cmd to FW before returning failure
from reset routine
>         d. Adds print in megasas_transition routine
>         e. Sends "RESET" flag to FW to do a soft reset of controller 
> to move from Operational to Ready state.
> 	f. Sending correct pointer (cmd->sense) to pci_pool_free
>           
>         This patch has been generated on latest scsi-misc git.
> 
> Signed-off-by: Sumant Patro <[email protected]>

Every one of these patches had extra whitespace at the end of several
lines.  This is a sample from the first patch:

Adds trailing whitespace.
.dotest/patch:21:       if (fw_state != MFI_STATE_READY) 
Adds trailing whitespace.
.dotest/patch:44:               case MFI_STATE_BOOT_MESSAGE_PENDING:
Adds trailing whitespace.
.dotest/patch:85:        * Reduce the max supported cmds by 1. This is
to ensure that the 

Could you please try to ensure it doesn't happen in future ... it's time
consuming to clean it all up again.

Thanks,

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux