On Wed, Oct 04, 2006 at 09:40:29AM -0700, Andrew Morton wrote: > I think we can do a version which omits the kmalloc altogether: > if (__get_user(c, ubuf++)) > return -EFAULT; > > (Note the s/get_user/__get_user/) Nice. This eliminates the bulk of the get_user() overhead. And it can be merged into Inaky's enum solution too, for something that is both simple and efficient. Joe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer
- From: "Inaky Perez-Gonzalez" <[email protected]>
- Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer
- References:
- [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer
- From: Reinette Chatre <[email protected]>
- Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer
- From: Andrew Morton <[email protected]>
- Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer
- From: Joe Korty <[email protected]>
- Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer
- From: Andrew Morton <[email protected]>
- [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer
- Prev by Date: Re: netconsole not working on 2.6.17.6
- Next by Date: Re: [take19 0/4] kevent: Generic event handling mechanism.
- Previous by thread: Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer
- Next by thread: Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer
- Index(es):
 |