Re: [Patch] Remove unnecessary check in fs/fat/inode.c

Eric Sesterhenn <[email protected]> writes:

> since all callers dereference sb, and this function
> does so earlier too, we dont need the check.
>
> Signed-off-by: Eric Sesterhenn <[email protected]>
>
> --- linux-2.6.18-git21/fs/fat/inode.c.orig	2006-10-04 18:21:03.000000000 +0200
> +++ linux-2.6.18-git21/fs/fat/inode.c	2006-10-04 18:21:22.000000000 +0200
> @@ -1472,7 +1472,7 @@ int fat_flush_inodes(struct super_block 
>  		ret = writeback_inode(i1);
>  	if (!ret && i2)
>  		ret = writeback_inode(i2);
> -	if (!ret && sb) {
> +	if (!ret) {
>  		struct address_space *mapping = sb->s_bdev->bd_inode->i_mapping;
>  		ret = filemap_flush(mapping);
>  	}

Acked-by: OGAWA Hirofumi <[email protected]>

Thanks.
-- 
OGAWA Hirofumi <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [Patch] Remove unnecessary check in fs/fat/inode.c
    • From: Eric Sesterhenn <[email protected]>

• Prev by Date: [PATCH 05/14] spufs: Add infrastructure needed for gang scheduling
• Next by Date: Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer
• Previous by thread: [Patch] Remove unnecessary check in fs/fat/inode.c
• Next by thread: Re: [MIPS] Remove IT8172-based platforms, ITE 8172G and Globespan IVR support.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]