Re: [PATCH] Fix WARN_ON / WARN_ON_ONCE regression

On Tue, 2006-10-03 at 17:07 -0700, Andrew Morton wrote:

> 
> Perhaps the `static int __warn_once' is getting put in the same cacheline
> as some frequently-modified thing.   Perhaps try marking that as __read_mostly?
> 

I've tried marking static int __warn_once as __read_mostly.  However, it
did not help with reducing the cache miss :(

So I would suggest reversing the "Let WARN_ON/WARN_ON_ONCE return the
condition" patch.  It has just been added 3 days ago so reversing it
should not be a problem.

Tim
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Fix WARN_ON / WARN_ON_ONCE regression
    • From: Andrew Morton <[email protected]>

• References:
  • [PATCH] Fix WARN_ON / WARN_ON_ONCE regression
    • From: Tim Chen <[email protected]>
  • Re: [PATCH] Fix WARN_ON / WARN_ON_ONCE regression
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH 4/5] Generic BUG for powerpc
• Next by Date: [RFC] PATCH to fix rescan_partitions to return errors properly
• Previous by thread: Re: [PATCH] Fix WARN_ON / WARN_ON_ONCE regression
• Next by thread: Re: [PATCH] Fix WARN_ON / WARN_ON_ONCE regression
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]