Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers

* Andrew Morton <[email protected]> wrote:

> > I don't personally mind the patch, I just wanted to bring that issue 
> > up.
> 
> yup.  Perhaps we could add
> 
> #define IRQ_HANDLERS_DONT_USE_PTREGS
> 
> so that out-of-tree drivers can reliably do their ifdefing.

i'd suggest we do something like:

 #define __PT_REGS

so that backportable drivers can do:

  static irqreturn_t irq_handler(int irq, void *dev_id __PT_REGS)

instead of an #ifdef jungle. Older kernel bases can define __PT_REGS in 
their interrupt.h (or in the backported driver's header, in one place)

 #ifndef __PT_REGS
 # define __PT_REGS , struct pt_regs *regs
 #endif

this would minimize the direct impact in the source-code.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/3] IRQ: Typedef the IRQ flow handler function type
    • From: David Howells <[email protected]>
  • Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
    • From: Andrew Morton <[email protected]>

• Prev by Date: [patch] clockevents: drivers for i386, fix #2
• Next by Date: Re: linux/compat.h includes asm/signal.h causing problems
• Previous by thread: Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
• Next by thread: Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]