| From: Heikki Orsila<[email protected]>
|
| Some nitpicking about the patch follows..
|
| On Sat, Sep 30, 2006 at 02:24:35AM +0400, Eugeny S. Mints wrote:
| > +static long
| > +get_vtg(const char *vdomain)
| > +{
| > + long ret = 0;
|
| Unnecessary initialisation.
---
Many of us work in environments where initialization is in the coding
standard. It also helps with static analysis tools. CodingStyle seems to
be silent on the point, but points to Kernighan and Ritchie, who say
"These initializations are actually unnecessary, since all are zero, but
it's a good idea to make them explicit anyway."
Any reasonable compiler will avoid doing the initialization twice...
---
| ...
| > +static int cpu_vltg_show(void *md_opt, int *value)
| > +{
| > + int rc = 0;
| > + if (md_opt == NULL) {
| > + if ((*value = get_vtg("v1")) <= 0)
| > + return -EIO;
| > + }
| > + else {
| > + struct pm_core_point *opt = (struct pm_core_point *)md_opt;
| > + *value = opt->cpu_vltg;
| > + }
| > +
| > + return rc;
| > +}
|
| int rc is unnecessary because the function always returns 0. This
| happens in many places.
---
Wonder if he wrote it for a coding standard that requires single return
(so that the "return -EIO" would have been "rc=-EIO") and converted
it...
scott
--
scott preece
motorola mobile devices, il67, 1800 s. oak st., champaign, il 61820
e-mail: [email protected] fax: +1-217-384-8550
phone: +1-217-384-8589 cell: +1-217-433-6114 pager: [email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
