Arjan van de Ven wrote:
well... why not go one step further and eliminate the flags argument
entirely? And use pci_name() for the name (so eliminate the argument ;)
and always pass pdev as data, so that that argument can go away too....
that'll cover 99% of the request_irq() users for pci devices.. and makes
it really nicely simple and consistent.
Disagree. That would involve rewriting a lot of drivers.
flags: may or may not need sample-random flag.
name: is always the ethernet interface, for net drivers, or did you
forget from your irqbalance days? ;-)
data: in practice, is _rarely_ struct pci_dev. It's usually a
driver-private structure which is the structure most frequently
accessed. struct pci_dev* is rarely accessed inside the interrupt
handler, except maybe somewhere deep in an error handling path.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
