Hello,
> "Thomas Maier" <[email protected]> writes:
>
>> this is a patch for the packet writing module pktcdvd.
>> The patch adds a sysfs and a debugfs interface, a Kconfig
>> parameter to switch of the procfs interface off and a
>> bio write queue congestion handling for the driver.
>
> I think most of these changes are good. However, some comments:
>
> * There are many logically independent parts in this change, so they
> should be in separate patches. For example:
> - Introduce the DRIVER_NAME #define.
> - Add sysfs support.
> - Make procfs support optional.
> - Implement congestion control.
> - Move lots of functions around. (Is it needed at all?)
Oh, this is ugly for coding, since all is in the same file.
But i splitted the patch and will send all 4 parts again.
I moved the functions for grouping and better readability.
> * You need to add Signed-off-by.
Ok.
> * You should CC Andrew Morton and not Linus. These changes should live
> in -mm for a while before going into the main tree.
Ok, but the changes should not be harmful and easy, i think ;)
> * The patch is white space damaged. All lines that should start with a
> single space start with two spaces.
Ugly. Thanks for the hit, haven't noticed it.
Thanks
Thomas Maier
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
