Re: [PATCH] I2O: mark i2o_config broken on 64-bit

• To: Jeff Garzik <[email protected]>
• Subject: Re: [PATCH] I2O: mark i2o_config broken on 64-bit
• From: Roland Dreier <[email protected]>
• Date: Sun, 01 Oct 2006 09:11:30 -0700
• Authentication-results: sj-dkim-4.cisco.com; [email protected]; dkim=pass ( sig from cisco.com verified; );
• Cc: [email protected], Andrew Morton <[email protected]>, LKML <[email protected]>
• Dkim-signature: a=rsa-sha1; q=dns; l=322; t=1159719093; x=1160583093; c=relaxed/simple; s=sjdkim4002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; [email protected]; z=From:Roland=20Dreier=20<[email protected]> |Subject:Re=3A=20[PATCH]=20I2O=3A=20mark=20i2o_config=20broken=20on=2064-bit; X=v=3Dcisco.com=3B=20h=3DnWeI1TMVZcv6wi2Apl+PjNqsjbU=3D; b=CLWGq/q/kkJAYEDsttLrVKCHuaRrLX+rM4d8LQ1LYS+M2uuHyF0lKZT0z9TGEZKVerYrgqS9 RLTdMJRmDfVKsAOHev8eix5UeL4WNIGtKkkczU0DX57e28PlSczhdbGp;
• In-reply-to: <[email protected]> (Jeff Garzik's message of "Sun, 1 Oct 2006 11:56:36 -0400")
• References: <[email protected]>
• Sender: [email protected]
• User-agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux)

 > -			//TODO 64bit fix
 > +			//FIXME: broken on 64-bit
 >  			sg[i].addr_bus = (u32) p->phys;

This looks worse than just broken on 64 bit.  I didn't even attempt to
understand what's going on here, but would this even work on 32 bit
systems that have physical addresses above 4 gigs (eg i386 with PAE)?

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] I2O: mark i2o_config broken on 64-bit
    • From: Markus Lidel <[email protected]>

• References:
  • [PATCH] I2O: mark i2o_config broken on 64-bit
    • From: Jeff Garzik <[email protected]>

• Prev by Date: Re: [Ops] 2.6.18
• Next by Date: [PATCH] MTD: fix printk warning
• Previous by thread: [PATCH] I2O: mark i2o_config broken on 64-bit
• Next by thread: Re: [PATCH] I2O: mark i2o_config broken on 64-bit
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]