Kill the "function should return a value" warning, and use the standard
mechanism for deciding when a thread should stop.
Signed-off-by: Jeff Garzik <[email protected]>
---
Given the security-sensitive nature of the audit function, _perhaps_ the
omission of kthread_should_stop() was intentional. If so, it at least
deserves a comment. But I think this is more correct.
diff --git a/kernel/audit.c b/kernel/audit.c
index f9889ee..b9146b1 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -340,7 +340,7 @@ static int kauditd_thread(void *dummy)
{
struct sk_buff *skb;
- while (1) {
+ do {
skb = skb_dequeue(&audit_skb_queue);
wake_up(&audit_backlog_wait);
if (skb) {
@@ -368,7 +368,9 @@ static int kauditd_thread(void *dummy)
__set_current_state(TASK_RUNNING);
remove_wait_queue(&kauditd_wait, &wait);
}
- }
+ } while (!kthread_should_stop());
+
+ return 0;
}
int audit_send_list(void *_dest)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
