On Thu, 28 Sep 2006 20:56:27 +0100 Roger Gammans wrote:
> On Fri, Sep 29, 2006 at 12:37:37PM -0700, Randy Dunlap wrote:
> > Hm, I looked thru fs/bio.c and block/*.c and Documentation/Docbook/*.tmpl.
> > The best place that I see to put it right now is in
> > include/linux/bio.h, struct bio, field: bi_sector.
> >
> > What do you think of that?
>
> Well, ... Um. I can't think of anywhere better either, so how about
> this:-
>
> Signed-Off-By: Roger Gammans <[email protected]>
Looks OK to me. I would probably go for something a little
stronger, though, like:
sector_t bi_sector; /* block layer sector
* addresses are always in
* 512-byte units in Linux */
Jens, is something like this (above or below) OK with you?
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index 76bdaea..77a8e6b 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -70,7 +70,8 @@ typedef void (bio_destructor_t) (struct
> * stacking drivers)
> */
> struct bio {
> - sector_t bi_sector;
> + sector_t bi_sector; /* device address in 512 byte
> + sectors */
> struct bio *bi_next; /* request queue link */
> struct block_device *bi_bdev;
> unsigned long bi_flags; /* status, command, etc
> */
---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
