Andrew Morton wrote:
On Wed, 27 Sep 2006 21:36:28 -0700
Andrew Morton <[email protected]> wrote:
device_for_each_child()
All that being said, device_for_each_child() is rather broken by design.
It walks a list of items applying a function to them and bales out on
first-error.
Or, like scsi_sysfs.c, it stops when it meets the first match. Which is
a common thing to do.
There's no way in which the caller can know which items have been operated
on, nor which items have yet to be operated on, nor which item experienced
the failure. Any caller which is serious about error recovery presumably
won't use it, unless the callback function happens to be something which
makes no state changes.
A simple integer return error doesn't tell you all that information
either. The actor must obviously store that additional information
somewhere, if it cares.
But whatever. I give up. I'm going back to working on the libata
warnings each build spits out (iomap).
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
