* Daniel Walker <[email protected]> wrote:
> On closer inspection I still think this is wrong. (Although it looks
> really nice..) find below speaking only in term of !PREEMPT_RT ,
> > - } else if (oops_in_progress) {
> > - locked = spin_trylock(&up->port.lock);
> > - } else
> > - spin_lock(&up->port.lock);
> > + if (up->port.sysrq || oops_in_progress)
> > + locked = spin_trylock_irqsave(&up->port.lock, flags);
>
> Now in the new version interrupts are only off if you _get the lock_.
> Presumably the lock is taken in the calling function, but interrupts
> aren't disabled.
>
> I'm assuming the code is disabling interrupts for a good reason, I
> don't know enough about the code to say it isn't.
yeah, agreed - behavior now changed due to my patch. This is really
twisted code...
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
