From: Brian Walsh <[email protected]> The platform_notify call for Arm and PPC architectures needs to be called before the driver attaches to the device. The problem only presents itself when hotplugging certain devices while the driver is already loaded. Signed-off-by: Brian Walsh <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> --- drivers/base/core.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index bc9f35c..b224bb4 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -424,6 +424,10 @@ int device_add(struct device *dev) if ((error = kobject_add(&dev->kobj))) goto Error; + /* notify platform of device entry */ + if (platform_notify) + platform_notify(dev); + dev->uevent_attr.attr.name = "uevent"; dev->uevent_attr.attr.mode = S_IWUSR; if (dev->driver) @@ -488,10 +492,6 @@ int device_add(struct device *dev) class_intf->add_dev(dev, class_intf); up(&dev->class->sem); } - - /* notify platform of device entry */ - if (platform_notify) - platform_notify(dev); Done: kfree(class_name); put_device(dev); -- 1.4.2.1 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- [PATCH 41/47] drivers/base: check errors
- From: Greg KH <[email protected]>
- [PATCH 41/47] drivers/base: check errors
- References:
- [GIT PATCH] Driver Core patches for 2.6.18
- From: Greg KH <[email protected]>
- [PATCH 1/47] Documentation/ABI: devfs is not obsolete, but removed!
- From: Greg KH <[email protected]>
- [PATCH 2/47] deprecate PHYSDEV* keys
- From: Greg KH <[email protected]>
- [PATCH 3/47] class_device_create(): make fmt argument 'const char *'
- From: Greg KH <[email protected]>
- [PATCH 4/47] device_create(): make fmt argument 'const char *'
- From: Greg KH <[email protected]>
- [PATCH 5/47] Driver core: add const to class_create
- From: Greg KH <[email protected]>
- [PATCH 6/47] sysfs: Make poll behaviour consistent
- From: Greg KH <[email protected]>
- [PATCH 7/47] Debugfs: kernel-doc fixes for debugfs
- From: Greg KH <[email protected]>
- [PATCH 8/47] SYSFS: allow sysfs_create_link to create symlinks in the root of sysfs
- From: Greg KH <[email protected]>
- [PATCH 9/47] Suspend infrastructure cleanup and extension
- From: Greg KH <[email protected]>
- [PATCH 10/47] Suspend changes for PCI core
- From: Greg KH <[email protected]>
- [PATCH 11/47] make suspend quieter
- From: Greg KH <[email protected]>
- [PATCH 12/47] fix broken/dubious driver suspend() methods
- From: Greg KH <[email protected]>
- [PATCH 13/47] PM: define PM_EVENT_PRETHAW
- From: Greg KH <[email protected]>
- [PATCH 14/47] PM: PCI and IDE handle PM_EVENT_PRETHAW
- From: Greg KH <[email protected]>
- [PATCH 15/47] PM: video drivers and PM_EVENT_PRETHAW
- From: Greg KH <[email protected]>
- [PATCH 16/47] PM: USB HCDs use PM_EVENT_PRETHAW
- From: Greg KH <[email protected]>
- [PATCH 17/47] PM: issue PM_EVENT_PRETHAW
- From: Greg KH <[email protected]>
- [PATCH 18/47] updated Documentation/power/devices.txt
- From: Greg KH <[email protected]>
- [PATCH 19/47] PM: update docs for writing .../power/state
- From: Greg KH <[email protected]>
- [PATCH 20/47] PM: add kconfig option for deprecated .../power/state files
- From: Greg KH <[email protected]>
- [PATCH 22/47] PM: no suspend_prepare() phase
- From: Greg KH <[email protected]>
- [PATCH 23/47] PM: add /sys/power documentation to Documentation/ABI
- From: Greg KH <[email protected]>
- [PATCH 24/47] PM: device_suspend/resume may sleep
- From: Greg KH <[email protected]>
- [PATCH 25/47] PM: platform_bus and late_suspend/early_resume
- From: Greg KH <[email protected]>
- [PATCH 26/47] Driver core: add groups support to struct device
- From: Greg KH <[email protected]>
- [PATCH 27/47] Driver core: allow devices in classes to have no parent
- From: Greg KH <[email protected]>
- [PATCH 28/47] Driver core: add ability for classes to handle devices properly
- From: Greg KH <[email protected]>
- [PATCH 29/47] Driver core: add device_rename function
- From: Greg KH <[email protected]>
- [PATCH 30/47] Driver core: create devices/virtual/ tree
- From: Greg KH <[email protected]>
- [PATCH 31/47] Class: add support for class interfaces for devices
- From: Greg KH <[email protected]>
- [PATCH 32/47] Driver core: add ability for devices to create and remove bin files
- From: Greg KH <[email protected]>
- [PATCH 33/47] kobject: must_check fixes
- From: Greg KH <[email protected]>
- [PATCH 34/47] sysfs_remove_bin_file: no return value, dump_stack on error
- From: Greg KH <[email protected]>
- [PATCH 35/47] Driver core: fix comments in drivers/base/power/resume.c
- From: Greg KH <[email protected]>
- [PATCH 36/47] Driver core: fixed add_bind_files() definition
- From: Greg KH <[email protected]>
- [PATCH 37/47] add __must_check to device management code
- From: Greg KH <[email protected]>
- [PATCH 38/47] add CONFIG_ENABLE_MUST_CHECK
- From: Greg KH <[email protected]>
- [PATCH 39/47] v4l-dev2: handle __must_check
- From: Greg KH <[email protected]>
- [GIT PATCH] Driver Core patches for 2.6.18
- Prev by Date: [PATCH 41/47] drivers/base: check errors
- Next by Date: [PATCH 43/47] Driver Core: add ability for drivers to do a threaded probe
- Previous by thread: [PATCH 39/47] v4l-dev2: handle __must_check
- Next by thread: [PATCH 41/47] drivers/base: check errors
- Index(es):