Re: hvc_iseries.c: overwriting spin_lock_irqsave()

Hi Alexy,

On Mon, 25 Sep 2006 16:47:08 +0400 "Alexey Dobriyan" <[email protected]> wrote:
>
> Stephen, -git4 contains the following code
> 
> drivers/char/hvc_iseries.c:
> 
> static int put_chars(uint32_t vtermno, const char *buf, int count)
> {
>             unsigned long flags;
> 
>             spin_lock_irqsave(&consolelock, flags);
>             if (viochar_is_console(pi) && !viopath_isactive(pi->lp)) {
>                           spin_lock_irqsave(&consoleloglock, flags);
> 
> So, old flags are lost.

Ooops!  Thanks for the heads up, I will send a fix patch tomorrow.

-- 
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [POWERPC] fix spin lock nesting in hvc_iseries
    • From: Stephen Rothwell <[email protected]>

• References:
  • hvc_iseries.c: overwriting spin_lock_irqsave()
    • From: "Alexey Dobriyan" <[email protected]>

• Prev by Date: Re: [2/9] driver core fixes: device_register() retval check in platform.c
• Next by Date: Re: [PATCH] fix idiocy in asd_init_lseq_mdp()
• Previous by thread: hvc_iseries.c: overwriting spin_lock_irqsave()
• Next by thread: [POWERPC] fix spin lock nesting in hvc_iseries
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]