Re: [PATCH 18/28] kbuild: fail kernel compilation in case of unresolved module symbols

On Sun, Sep 24, 2006 at 11:20:26PM +0100, Al Viro wrote:
> On Sun, Sep 24, 2006 at 11:18:14PM +0200, [email protected] wrote:
> > From: Kirill Korotaev <[email protected]>
> > 
> > At stage 2 modpost utility is used to check modules.  In case of unresolved
> > symbols modpost only prints warning.
> > 
> > IMHO it is a good idea to fail compilation process in case of unresolved
> > symbols (at least in modules coming with kernel), since usually such errors
> > are left unnoticed, but kernel modules are broken.
> > 
> > - new option '-w' is added to modpost:
> >   if option is specified, modpost only warns about unresolved symbols
> > 
> > - modpost is called with '-w' for external modules in Makefile.modpost
> 
> Oh, joy...  Could you add a way to tell kbuild that old behaviour is,
> in fact, desired?  make MODPOST_FLAGS=-w or something along these lines...

On what architectures do you see lots of these warnings - maybe fixable?
Otherwise I could do something like this:

diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
index 4b2721c..e9efe61 100644
--- a/scripts/Makefile.modpost
+++ b/scripts/Makefile.modpost
@@ -58,7 +58,7 @@ quiet_cmd_modpost = MODPOST $(words $(fi
 	$(if $(KBUILD_EXTMOD),-i,-o) $(kernelsymfile) \
 	$(if $(KBUILD_EXTMOD),-I $(modulesymfile)) \
 	$(if $(KBUILD_EXTMOD),-o $(modulesymfile)) \
-	$(if $(KBUILD_EXTMOD),-w) \
+	$(if $(KBUILD_EXTMOD)$(KBUILD_MODPOST_WARN),-w) \
 	$(wildcard vmlinux) $(filter-out FORCE,$^)
 
 PHONY += __modpost

Then:
make KBUILD_MODPOST_WARN=1

would warn and not fail.

Note: I beleive the patch has been in -mm for a while.
      Got the patch via akpm

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 18/28] kbuild: fail kernel compilation in case of unresolved module symbols
    • From: Al Viro <[email protected]>

• References:
  • [PATCH 10/28] kbuild: ignore references from ".pci_fixup" to ".init.text"
    • From: [email protected]
  • [PATCH 11/28] kbuild: modpost on vmlinux regardless of CONFIG_MODULES
    • From: [email protected]
  • [PATCH 12/28] kbuild: make V=2 tell why a target is rebuild
    • From: [email protected]
  • [PATCH 13/28] kbuild: make -rR is now default
    • From: [email protected]
  • [PATCH 14/28] kbuild: preperly align SYSMAP output
    • From: [email protected]
  • [PATCH 15/28] kbuild: add missing return statement in modpost.c:secref_whitelist()
    • From: [email protected]
  • [PATCH 16/28] kbuild: create output directory for hostprogs with O=.. build
    • From: [email protected]
  • [PATCH 17/28] kbuild: remove debug left-over from Makefile.host
    • From: [email protected]
  • [PATCH 18/28] kbuild: fail kernel compilation in case of unresolved module symbols
    • From: [email protected]
  • Re: [PATCH 18/28] kbuild: fail kernel compilation in case of unresolved module symbols
    • From: Al Viro <[email protected]>

• Prev by Date: Re: [PATCH] [V4L] Support for SAA7134-based AVerTV Hybrid A16AR
• Next by Date: Re: [git patches] ocfs2 post 2.6.18 features
• Previous by thread: Re: [PATCH 18/28] kbuild: fail kernel compilation in case of unresolved module symbols
• Next by thread: Re: [PATCH 18/28] kbuild: fail kernel compilation in case of unresolved module symbols
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]