Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]

Pekka Enberg wrote:

On 9/22/06, Paulo Marques <[email protected]> wrote:

Agreed on every comment except this one. That complex expression is
really just a constant in the end, so there is no point in using kcalloc.

The code is arguably easier to read with kcalloc.

I was afraid the kcalloc call would have the added overhead of an extra parameter and a multiplication, but since it is actually declared as a static inline, gcc should optimize everything away (because both parameters are constants) and give the same result in the end.

So, its fine by me either way.

--
Paulo Marques - www.grupopie.com

"The face of a child can say it all, especially the
mouth part of the face."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]
    • From: "Dmitry Torokhov" <[email protected]>

• References:
  • kmalloc to kzalloc patches for drivers/block [sane version]
    • From: "Om Narasimhan" <[email protected]>
  • Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]
    • From: Nishanth Aravamudan <[email protected]>
  • Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]
    • From: "Om Narasimhan" <[email protected]>
  • Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]
    • From: "Om Narasimhan" <[email protected]>
  • Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]
    • From: Jiri Slaby <[email protected]>
  • Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]
    • From: Paulo Marques <[email protected]>
  • Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]
    • From: "Pekka Enberg" <[email protected]>

• Prev by Date: Re: "set_rtc_mmss: can't update from m to n" cluttering my logs
• Next by Date: Re: Bcm43xx softMac Driver in 2.6.18
• Previous by thread: Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]
• Next by thread: Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]