Re: [PATCH 1/1 Re] drivers: add lcd display support

[Pavel Machek <pavel@ucw.cz>]

Hi!

> Please tell me if you agree.
> 
> Adds LCD Display support.
> Adds ks0108 LCD controller support.
> Adds cfag12864b LCD display support.
> 
> Signed-off-by: Miguel Ojeda Sandonis <maxextreme@gmail.com>


> diff -uprN -X linux-2.6.18-rc7/Documentation/dontdiff linux-2.6.18-rc7-vanilla/drivers/lcddisplay/cfag12864b.c linux-2.6.18-rc7/drivers/lcddisplay/cfag12864b.c
> --- linux-2.6.18-rc7-vanilla/drivers/lcddisplay/cfag12864b.c	1970-01-01 01:00:00.000000000 +0100
> +++ linux-2.6.18-rc7/drivers/lcddisplay/cfag12864b.c	2006-09-13 05:03:29.000000000 +0200
> @@ -0,0 +1,558 @@
> +/*
> + *    Filename: cfag12864b.c
> + *     Version: 0.1.0
> + * Description: cfag12864b LCD Display Driver
> + *     License: GPL

v2 or v2 and later? 

> +static const unsigned int cfag12864b_firstminor = 0;

No need to initialize to zero.

> +static const unsigned int cfag12864b_ndevices = 1;
> +static const char * cfag12864b_name = NAME;
                      ~- kill this space.

> +#define bit(n) ((unsigned char)(1<<(n)))
> +#define nobit(n) ((unsigned char)(~bit(n)))

Uh? We have generic functions for this.

> +static unsigned char cfag12864b_state = 0;

No zeros.

> +static void cfag12864b_e(unsigned char state)
> +{
> +	if(state)
          ~ missing space.

> +		cfag12864b_state |= bit(0);
> +	else
> +		cfag12864b_state &= nobit(0);
> +	cfag12864b_set();

This repeats few times, perhaps you could create helper for that?
> +static void cfag12864b_secondcontroller(unsigned char state)
> +{
> +	if(state)
> +		cfag12864b_cs2(0);
> +	else
> +		cfag12864b_cs2(1);
> +}

Is this needed?

> +		/*if(address != tmpaddress) {
> +			address = tmpaddress;
> +			cfag12864b_address(address);
> +			cfag12864b_nop();
> +		}*/
> +
> +		/*if(tmpcontroller == 0) {
> +			if(address != tmpaddress) {
> +				address = tmpaddress;
> +				cfag12864b_address(address);
> +			}
> +		}
> +		else {
> +			cfag12864b_address(tmpaddress);
> +			cfag12864b_nop();
> +		}*/

Remove unused code, do not comment it out.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/