Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3]

Andrew Morton <[email protected]> wrote:

> This breaks ia64:

Okay, drop it for now.

> But for some reason putting ARCH_HAS_GET_ORDER into
> include/asm-ia64/bitops.h and including linux/log2.h in
> include/asm-ia64/page.h doesn't fix it.

Seems I need to get an IA64 cross-compiler.

> I didn't pursue it further, because sprinkling ARCH_HAS_FOO things into
> bitops.h(!) is all rather hacky.  Better to use CONFIG_* so they're always
> visible and one knows where to go to find things.

But (1) they're not config options, and (2) there's plenty of precedent for
this sort of thing (ARCH_HAS_PREFETCH for example).

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3]
  - From: Andrew Morton <[email protected]>

References:
- Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3]
  - From: Andrew Morton <[email protected]>
- [PATCH 1/7] FRV: Fix fls() to handle bit 31 being set correctly [try #3]
  - From: David Howells <[email protected]>
- [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3]
  - From: David Howells <[email protected]>

Prev by Date: Re: patch blocked
Next by Date: Re: FS-Cache patches
Previous by thread: Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3]
Next by thread: Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3]
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]