RE: [patch 3/3] Add tsi108 On Chip Ethernet device driver support

> 
> I have some review comments about your driver; please 
> consider them for
> fixing....
> 
Thanks.
> 
> > +		spin_unlock_irq(&phy_lock);
> > +		msleep(10);
> > +		spin_lock_irq(&phy_lock);
> > +	}
> 
> hmm some places take phy_lock with disabling interrupts, while others
> don't. I sort of fear "the others" may be buggy.... are you sure those
> are ok?
Could you interpret your comments in detail?
Roy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • RE: [patch 3/3] Add tsi108 On Chip Ethernet device driver support
    • From: Arjan van de Ven <[email protected]>

• References:
  • Re: [patch 3/3] Add tsi108 On Chip Ethernet device driver support
    • From: Arjan van de Ven <[email protected]>

• Prev by Date: Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3]
• Next by Date: Re: [linux-pm] PowerOP vs OPpoint
• Previous by thread: Re: [patch 3/3] Add tsi108 On Chip Ethernet device driver support
• Next by thread: RE: [patch 3/3] Add tsi108 On Chip Ethernet device driver support
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]