Re: Sysenter crash with Nested Task Bit set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Andi Kleen <[email protected]> wrote:

> >  #define switch_to(prev,next,last) do {					\
> >  	unsigned long esi,edi;						\
> > -	asm volatile("pushl %%ebp\n\t"					\
> > +	asm volatile("pushfl\n\t"		/* Save flags */	\
> > +		     "pushl %%ebp\n\t"					\
> 
> We used to do that pushfl/popfl some time ago, but Ben removed it 
> because it was slow on P4.  Ok, nobody thought of that case back then.

I _should_ have thought of that though, because when this change was 
done originally i had to reintroduce it both for exec-shield and for 
-rt, so apparently it must have triggered in certain circumstances - i 
just didnt notice the reason. (but recent exec-shield and -rt patches 
dont have this revert, so the condition must have gone away. But it was 
a long time ago.)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux