Re: Exporting array data in sysfs

[Rolf Eike Beer <eike-kernel@sf-tec.de>]

Dmitry Torokhov wrote:
> On 9/18/06, Rolf Eike Beer <eike-kernel@sf-tec.de> wrote:
> > Greg KH wrote:
> > > On Mon, Sep 18, 2006 at 01:59:17PM +0200, Rolf Eike Beer wrote:
> > > > Hi,
> > > >
> > > > I would like to put the contents of an array in sysfs files. I found
> > > > no simple way to do this, so here are my thoughts in hope someone can
> > > > hand me a light.
> > >
> > > What is wrong with using an attribute group for this kind of
> > > information?
> >
> > Missing documentation. Yes, this looks like I could use this at least for
> > the simple interfaces (which would be enough).
>
> I imoplemented sysfs arrays and array groups once:
>
> http://www.ussg.iu.edu/hypermail/linux/kernel/0503.2/1155.html
>
> Not sure if it still appliers. Maybe Greg will consider taking it in
> if there is a user of this code.

I guess we can add some once it is in :)

It looks good, but I would change some minor things. If there is no read 
function given I would return -EIO instead of 0, this is how other places do 
it. The limitation to 999 entries should go. But otherwise it looks very 
similar to what I had in mind.

Thanks.

Eike

Attachment: pgptPpSAYa4Wr.pgp
Description: PGP signature