Re: [PATCH] mpparse.c:231: warning: comparison is always false

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 15, 2006 at 12:33:40PM -0700, Andrew Morton wrote:
> On Fri, 15 Sep 2006 11:23:49 -0400
> Dave Jones <[email protected]> wrote:
> 
> > On Fri, Sep 15, 2006 at 01:23:02AM -0700, Andrew Morton wrote:
> > 
> >  > > > Thanks.   Andi has already queued a similar patch.
> >  > > > 
> >  > > > Andi, you might as well scoot that upstream, otherwise we'll get lots of
> >  > > > emails about it.
> >  > > ...
> >  > > > > +#if 0xFF >= MAX_MP_BUSSES
> >  > > > >  	if (m->mpc_busid >= MAX_MP_BUSSES) {
> >  > > I don't know how Andi has fixed it,
> >  > Same thing.  (He has `#if MAX_MP_BUSSES < 256').
> > 
> > How can this be the right the right thing to do ?
> > It should *never* be >=256. mach-summit/mach-generic need fixing
> > to be 255, not this ridiculous band-aid.  Where did 260 come from anyway?
> >  
> 
> commit f0bacaf5cec4e677a00b5ab06d95664d03a30f7a
> Author: akpm <akpm>
> Date:   Mon Apr 12 20:06:32 2004 +0000
> 
>     [PATCH] summmit: increase MAX_MP_BUSSES
>     
>     From: James Cleverdon <[email protected]>
>     
>     Bump up MAX_MP_BUSSES for summit/generic subarch to cope with big IBM x440
>     systems.

The 260 is because ACPI can create larger busses and the summit
boxes only run with ACPI anyways.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux