Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi David,

On Thu, 14 Sep 2006 12:52:04 +0100 David Howells <[email protected]> wrote:
>
> Stephen Rothwell <[email protected]> wrote:
> 
> > After this patch, you don't need to include <linux/compiler.h> any more
> > (and, in fact, the file ends up essentially empty).
> 
> True.  I could possibly delete the whole file, depending on who else has
> designs on it.

I think the patch consolidating PAGE_SIZE may want it.

> > Is there a good reason to move this function out of asm-generic/page.h?
> 
> So that all the general log2-based functions are grouped together was what I
> was thinking (at least their primary interfaces).

Except the get_order() interface is purely related to pages (the fact
that you have reimplemented it using the log2-based functions is just an
implementation detail.

-- 
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux