Re: [01/12] driver core fixes: make_class_name() retval check

hoi :)

On Wed, Sep 13, 2006 at 06:38:34PM +0200, Cornelia Huck wrote:
>  	if (class_dev->dev) {
>  		class_name = make_class_name(class_dev->class->name,
>  					     &class_dev->kobj);
> +		if (IS_ERR(class_name)) {
> +			error = PTR_ERR(class_name);
> +			class_name = NULL;
> +			goto out6;
> +		}

perhaps it makes sense to return NULL in make_class_name on error,
to have consistent error return values?

-- 
Martin Waitz

Attachment: signature.asc
Description: Digital signature

---

• Follow-Ups:
  • Re: [01/12] driver core fixes: make_class_name() retval check
    • From: Cornelia Huck <[email protected]>

• References:
  • [01/12] driver core fixes: make_class_name() retval check
    • From: Cornelia Huck <[email protected]>

• Prev by Date: Re: [PATCH] mpparse.c:231: warning: comparison is always false
• Next by Date: Re: [RFC] Watchdog device class
• Previous by thread: [01/12] driver core fixes: make_class_name() retval check
• Next by thread: Re: [01/12] driver core fixes: make_class_name() retval check
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]