AW: fix 2.4.33.3 / sun partition size

["Jurzitza, Dieter" <DJurzitza@harmanbecker.com>]

Hi Willy,
> It would really depend on the on-disk format. If the 
> partition table really stores 32 bit ints for sector counts, 
> there's no point switching from ints to longs. But if it 
> already stores 64 bits, then we're limiting it to 2 TB with 
> 32 bit ints. I haven't checked the code right now, so I don't 
> know. I hope Davem will enlighten us on this matter.
> 
I see your point. The question is: what happens if we forcibly cast a 8 byte unsigned long into a 4 byte (unsigned ...) int.
One point is only sun related here: the 1/2TByte limit for sun partitions. The other things are generic ones, independent of the architecture but no: at the very moment that a long differs in size from an int we run into problems IMHO. It's unclean, at last.
Do you think it would be better to do an explicit cast in each call to pinpoint the issue?
Thanks for your inputs, and, yes, it's been quiet on sparclinux, it sounds like Dave Miller is (hopefully!) off for holidays - and I think he deserves it, doesn't he :-) ?
Take care



Dieter


-- 
________________________________________________

HARMAN BECKER AUTOMOTIVE SYSTEMS

Dr.-Ing. Dieter Jurzitza
Manager Hardware Systems
   System Development

Industriegebiet Ittersbach
Becker-Göring Str. 16
D-76307 Karlsbad / Germany

Phone: +49 (0)7248 71-1577
Fax:   +49 (0)7248 71-1216
eMail: DJurzitza@harmanbecker.com
Internet: http://www.becker.de


*******************************************
Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtuemlich erhalten haben, informieren Sie bitte sofort den Absender und loeschen Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet.
 
This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and delete this e-mail. Any unauthorized copying, disclosure or distribution of the contents in this e-mail is strictly forbidden.
*******************************************

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/