On 9/12/06, Alexey Dobriyan <[email protected]> wrote:
arrrrggg.... I'm in the middle of reading every module_init and every
module_exit func, and this starts getting really annoying....
Anyway, thank you for you time reviewing it. :)
5. In case of error during initialization, error code SHOULD be
propagated as is to upper layers, either via direct
assignment/return or via decoding from pointer.
What do you mean? I thought returning the error code was enough.
6. Error messages SHOULD start with short unique prefix specific to
driver. Module name without .o and .ko is fine.
They do 8)
#define PRINTK_PREFIX PRINTK_INFO NAME ": "
printk(PRINTK_PREFIX "Init... ");
Then, if a error appears: printk("ERROR - kmalloc\n");
Final string: "<i>cfag12864b: Init... ERROR - kmalloc"
The only bad point: If some other printk is called from other module
between. Should I change it?
Miguel Ojeda
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
