Re: [PATCH] fix warning: no return statement in function returning non-void in kernel/audit.c

Jesper Juhl <[email protected]> wrote:
> kauditd_thread() is being used in a call to kthread_run(). kthread_run()
> expects a function returning 'int' which is also how kauditd_thread() is
> declared. Unfortunately kauditd_thread() neglects to return a value

It is an infinite loop...
>                                                                     which
> results in this complaint from gcc :

>   kernel/audit.c:372: warning: no return statement in function returning non-void

> Easily fixed by just adding a 'return 0;' to kauditd_thread().

How about marking it as never returning?
-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                     Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria              +56 32 654239
Casilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fix warning: no return statement in function returning non-void in kernel/audit.c
    • From: "Jesper Juhl" <[email protected]>

• References:
  • [PATCH] fix warning: no return statement in function returning non-void in kernel/audit.c
    • From: Jesper Juhl <[email protected]>

• Prev by Date: cpufreq terminally broken [was Re: community PM requirements/issues and PowerOP]
• Next by Date: Re: [RFC] MMIO accessors & barriers documentation
• Previous by thread: Re: [PATCH] fix warning: no return statement in function returning non-void in kernel/audit.c
• Next by thread: Re: [PATCH] fix warning: no return statement in function returning non-void in kernel/audit.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]