On 09/10, Eric W. Biederman wrote:
>
> Oleg Nesterov <[email protected]> writes:
>
> > On 09/09, Eric W. Biederman wrote:
> >>
> >> This patch does several things.
> >> - The variables used are moved into a structure and declared in vt_kern.h
> >> - A spinlock is added so we don't have SMP races updating the values.
> >> - Instead of raw pid_t value a struct_pid is used to guard against
> >> pid wrap around issues, if the daemon to spawn a new console dies.
> >
> > I am not arguing against this patch, but it's a pity we can't use 'struct pid'
> > lockless. What dou you think about this:
>
> Actually with xchg I can use a reference counted struct pid lockless.
>
> ...
>
> Perhaps:
> void update_pid(struct pid **ref, struct pid *new)
> {
> struct pid *old;
> get_pid(new);
> old = xchg(ref, new);
> put_pid(old);
> }
This can't work. This put_pid() can actually free the memory, while
'old' is still in use (lockless).
> rcu is definitely not the solution in these cases as the struct pid
> is stored for a long time so we need the reference count.
Surely we need the reference count, I don't understand you.
Look at put_pid_rcu().
That said,
> In the general case you have more then one variable you want to keep
> in sync and you need the lock for that.
Yes.
> But since I can write it as a moderately clear one liner in the
> case that matters I don't much care.
Ok.
Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
