Re: set power state of firewire host during suspend

Pavel Machek wrote:
> Put firewire host controller in PCI Dx state for system suspend.
> (I was not able to measure any power savings, but it sounds like right
> thing to do, anyway.)
> 
> Signed-off-by: Pavel Machek <[email protected]>
[...]
> --- a/drivers/ieee1394/ohci1394.c
> +++ b/drivers/ieee1394/ohci1394.c
> @@ -3565,6 +3565,7 @@ static int ohci1394_pci_suspend (struct 
>  	}
>  #endif
>  
> +	pci_set_power_state(pdev, pci_choose_state(pdev, state));
>  	return 0;
>  }

The order with existing PPC_PMAC code needs to be swapped. And the
resume hook should set the power state too, right? I will post an update
patch soon.
-- 
Stefan Richter
-=====-=-==- =--= --===
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • set power state of firewire host during suspend
    • From: Pavel Machek <[email protected]>

• Prev by Date: Re: patch to make Linux capabilities into something useful (v 0.3.1)
• Next by Date: Re: [PATCH] IA64,sparc: local DoS with corrupted ELFs
• Previous by thread: Re: set power state of firewire host during suspend
• Next by thread: intel_agp and EFI (Intel MacBook)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]