On Sun, 2006-09-03 at 23:40 -0700, David Brownell wrote: > > > Going through the ethtool operations, I think that it should be > > possible to implement a few of them, including ETHTOOL_GREGS, > > ETHTOOL_GEEPROM, ETHTOOL_SEEPROM, ETHTOOL_NWAY_RST and ETHTOOL_GPERMADDR. > > Do you think these should be done? > > I've not got much use for those, but maybe the netdev folk would > care. That's probably not enough to hold up any merge. Definitely not showstoppers, but nice touches just to ensure that all things work as expected. The ones of most importance as I see it are the get/set_settings ones, which you can just pass-thru to the mii_ethtool_Xset() calls and get_drvinfo(). All others are somewhat optional and do vary from device to device. -- David Hollis <[email protected]>
Attachment:
signature.asc
Description: This is a digitally signed message part
- References:
- [PATCH] please review mcs7830 (DeLOCK USB etherner) driver
- From: Arnd Bergmann <[email protected]>
- [PATCH] driver for mcs7830 (aka DeLOCK) USB ethernet adapter
- From: Arnd Bergmann <[email protected]>
- Re: [linux-usb-devel] [PATCH] driver for mcs7830 (aka DeLOCK) USB ethernet adapter
- From: David Brownell <[email protected]>
- Re: [linux-usb-devel] [PATCH] driver for mcs7830 (aka DeLOCK) USB ethernet adapter
- From: Arnd Bergmann <[email protected]>
- Re: [linux-usb-devel] [PATCH] driver for mcs7830 (aka DeLOCK) USB ethernet adapter
- From: David Brownell <[email protected]>
- [PATCH] please review mcs7830 (DeLOCK USB etherner) driver
- Prev by Date: Re: [PATCH] ext3_getblk should handle HOLE correctly
- Next by Date: Re: patch to make Linux capabilities into something useful (v 0.3.1)
- Previous by thread: Re: [linux-usb-devel] [PATCH] driver for mcs7830 (aka DeLOCK) USB ethernet adapter
- Next by thread: [PATCH] fix hrtimer percpu usage typo
- Index(es):
 |