Re: Linux 2.6.18-rc6

[Olaf Hering <olaf@aepfle.de>]

On Wed, Sep 06, James Bottomley wrote:

> On Wed, 2006-09-06 at 13:01 +0200, Olaf Hering wrote:
> > This causes another machine check because it runs ahc_inb(ahc, SBLKCTL) again.
> > With debug I get:
> 
> Exactly.  It's not a card state problem; the register simply doesn't
> exist.  It looks like from the source code, it only exists on twin or U2
> and above chipsets (i.e. those supporting LVD).
> 
> Try this patch, which should deduce the bus type for U and below without
> resorting to the SBLKCTL register.
> 
> James
> 
> diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> index e5bb4d8..0b3c01a 100644
> --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
> +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> @@ -2539,15 +2539,23 @@ #endif
>  static void ahc_linux_get_signalling(struct Scsi_Host *shost)
>  {
>  	struct ahc_softc *ahc = *(struct ahc_softc **)shost->hostdata;
> -	u8 mode = ahc_inb(ahc, SBLKCTL);
> +	u8 mode;
>  
> -	if (mode & ENAB40)
> -		spi_signalling(shost) = SPI_SIGNAL_LVD;
> -	else if (mode & ENAB20)
> +	if (!(ahc->features & AHC_ULTRA2)) {

This does not work: ahc_linux_get_signalling: f 56f6

echo $(( 0x56f6 & 0x00002 )) gives 2, and the ahc_inb is called.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/