Re: [PATCH] x86 microcode: don't check the size

Shaohua Li wrote:

IA32 manual says if micorcode update's size is 0, then the size is
default size (2048 bytes). But this doesn't suggest all microcode
update's size should be above 2048 bytes to me. We actually had a
microcode update whose size is 1024 bytes. The patch just removed the
check.

Signed-off-by: Shaohua Li <[email protected]>

Why not explicitly check for zero, rather than removing the questionable less-than test? The default size logic hasn't disappeared...

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] x86 microcode: don't check the size
    • From: Shaohua Li <[email protected]>

• References:
  • [PATCH] x86 microcode: don't check the size
    • From: Shaohua Li <[email protected]>

• Prev by Date: Re: [NEW PATCH] VIA IRQ quirk behaviour change
• Next by Date: Re: [-mm patch] ACPI_SONY shouldn't default m
• Previous by thread: [PATCH] x86 microcode: don't check the size
• Next by thread: Re: [PATCH] x86 microcode: don't check the size
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]