Re: [RFC][PATCH] fail kernel compilation in case of unresolved symbols

[Sam Ravnborg <sam@ravnborg.org>]

On Wed, Sep 06, 2006 at 07:05:10PM +0400, Kirill Korotaev wrote:
> Sam Ravnborg wrote:
> >On Tue, Sep 05, 2006 at 05:47:25PM +0400, Kirill Korotaev wrote:
> >
> >>At stage 2 modpost utility is used to check modules.
> >>In case of unresolved symbols modpost only prints warning.
> >>
> >>IMHO it is a good idea to fail compilation process in case of
> >>unresolved symbols, since usually such errors are left unnoticed,
> >>but kernel modules are broken.
> >
> >
> >The primary reason why we do not fail in this case is that building
> >external modules often result in unresolved symbols at modpost time.
> >
> >And there is many legitime uses of external modules that we shall support.
> ok. is it ok for you to introduce new Make target 'modules_check'?
In top-level Makefile we already distingush between external modules and
internal modules. See the different calls to Makefile.modpost

Could you try updating your patch so in the normal case we exit with
a fail in case of unresolved symbols but if a specific flag is specified
we only warn on unresolved symbols.

And then introduce the nw flag only for external modules in the
top-level Makefile.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/