[PATCH] take 4 Re: VIA IRQ quirk, another (embarrassing) suggestion.

[Sergio Monteiro Basto <sergio@sergiomb.no-ip.org>]

On Tue, 2006-09-05 at 11:13 -0400, Jeff Garzik wrote:
> Sergio Monteiro Basto wrote:
> > On Mon, 2006-09-04 at 11:33 -0700, Chris Wedgwood wrote:
> >> On Mon, Sep 04, 2006 at 12:54:07PM +0100, Sergio Monteiro Basto wrote:
> >>
> >>> I don't know if this is a real question. Have we VIA products on PCI
> >>> card, running on not VIA chip sets ?
> >> Yes.  Certainly for on-board devices too.
> > 
> > OK , other argument.
> > We have billions of VIA chip sets with VIA PCI on-board and 
> > VIA PCI on others chip sets, if exists, are a very few.
> > So, because some exceptions, we shouldn't stop a resolution of a very
> > large % of the cases. 
> 
> No thanks.  As VIA SATA maintainer, I like being able to use my VIA SATA 
> PCI card.
> 
> 	Jeff

I have 2 computer with 2 different Asrock
(http://www.asrock.com/product/775Dual-880Pro.htm) boards, both have a
VIA8237 and a VIA SATA, and both are quirked wrongly, when I use kernels
2.6.17+ . 
And if I haven't bought this 2 computers in a supermarket, I won't be
here discussion this subjects.

So I like to remember  
http://lkml.org/lkml/2006/7/28/264
http://lkml.org/lkml/2006/9/4/111 ( that confirm a VIA SATA on XT-PIC
mode ) http://lkml.org/lkml/2006/9/1/106 )

So VIA SATA needs my patch or Daniel Drake patch to _WORK_ .

Adding my patch to Daniel Drake patch ( that is already on -mm series )
could be a reasonable solution.

Patch for 2.6.18-rc5-mm1

Cc: Daniel Drake <dsd@gentoo.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Scott J. Harmon" <harmon@ksu.edu>
Cc: Andrew Morton <akpm@osdl.org>
Cc: Chris Wedgwood <cw@f00f.org>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Sergio Monteiro Basto <sergio@sergiomb.no-ip.org
diff linux-2.6.17.x86_64/drivers/pci/quirks.c.orig linux-2.6.17.x86_64/drivers/pci/quirks.c -up
--- linux-2.6.17.x86_64/drivers/pci/quirks.c.orig       2006-09-06 02:03:09.000000000 +0100
+++ linux-2.6.17.x86_64/drivers/pci/quirks.c    2006-09-06 02:05:44.000000000 +0100
@@ -654,6 +654,14 @@ static void quirk_via_irq(struct pci_dev
 {
        u8 irq, new_irq;

+#ifdef CONFIG_X86_IO_APIC
+       if (nr_ioapics && !skip_ioapic_setup)
+               return;
+#endif
+#ifdef CONFIG_ACPI
+       if (acpi_irq_model != ACPI_IRQ_MODEL_PIC)
+               return;
+#endif
        if (via_irq_fixup_needed == -1)
                via_irq_fixup_needed = pci_dev_present(via_irq_fixup_tbl);

@@ -663,7 +671,7 @@ static void quirk_via_irq(struct pci_dev
        new_irq = dev->irq & 0xf;
        pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq);
        if (new_irq != irq) {
-               printk(KERN_INFO "PCI: VIA IRQ fixup for %s, from %d to %d\n",
+               printk(KERN_INFO "PCI: VIA PIC IRQ fixup for %s, from %d to %d\n",
                        pci_name(dev), irq, new_irq);
                udelay(15);     /* unknown if delay really needed */
                pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);


Thanks,
-- 
Sérgio M. B.

Attachment: smime.p7s
Description: S/MIME cryptographic signature