On Tue, 2006-09-05 at 10:43 +0200, Ingo Molnar wrote:
> * Steven Whitehouse <[email protected]> wrote:
[some lines snipped]
> > > >+ if ((char *)cur + cur_rec_len >= bh_end) {
> > > >+ if ((char *)cur + cur_rec_len > bh_end) {
> > > >+ gfs2_consist_inode(dip);
> > > >+ return -EIO;
> > > >+ }
> > > >+ return -ENOENT;
> > > >+ }
> > >
> > > if((char *)cur + cur_rec_len > bh_end) {
> > > gfs2_consist_inode(dip);
> > > return -EIO;
> > > } else if((char *)cur + cur_rec_len == bh_end)
> > > return -ENOENT;
> > >
> > ok
>
> this one is not OK! Firstly, Jan, and i mentioned this before, please
> stop using 'if(', it is highly inconsistent and against basic taste. We
> only use this construct for function calls (and macros), not for C
> statements.
I did use use if "if (" form when I made this change rather than a
direct copy & paste from this. So it is ok I think,
Steve.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
