>+static struct kset gfs2_kset = {
>+ .subsys = &fs_subsys,
>+ .kobj = {.name = "gfs2",},
I think
.kobj = {.name = "gfs2"},
would suffice style-wise (, only looks good on multiple lines IMO, but anyone
who wants to object may scream out loud *now*).
>+ .ktype = &gfs2_ktype,
>+};
>+/* one oddball doesn't fit the macro mold */
>+static ssize_t noatime_show(struct gfs2_sbd *sdp, char *buf)
>+{
>+ return sprintf(buf, "%d\n", !!test_bit(SDF_NOATIME, &sdp->sd_flags));
>+}
Hm, what does test_bit return, if not 0 or 1? (Questioning the
possible redundancy of !!)
Jan Engelhardt
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
