KAMEZAWA Hiroyuki <[email protected]> writes:
> On Mon, 04 Sep 2006 17:13:10 -0600
> [email protected] (Eric W. Biederman) wrote:
> Hi, Hit OOM-Killer, because of memory leak of task struct.
>
> patch is attached.
> -Kame
>
> task struct should be put always.
Good catch. I actually have a pending cleanup that works better if the
task struct is held across the filldir so the incremental patch should look like:
I also noticed a benign typo in TGID_OFFSET (1 subtract one that I shouldn't)
Complete patch in just a moment.
Eric
diff --git a/fs/proc/base.c b/fs/proc/base.c
index b7650b9..03f6680 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -2186,7 +2186,7 @@ int proc_pid_readdir(struct file * filp,
tgid = filp->f_pos - TGID_OFFSET;
for (task = next_tgid(tgid);
task;
- task = next_tgid(tgid + 1)) {
+ put_task_struct(task), task = next_tgid(tgid + 1)) {
int len;
ino_t ino;
tgid = task->pid;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
